pgsql: Improve ICU option handling in CREATE DATABASE

Improve ICU option handling in CREATE DATABASE

We check that the ICU locale is only specified if the ICU locale
provider is selected.  But we did that too early.  We need to wait
until we load the settings of the template database, since that could
also set what the locale provider is.

Reported-by: Marina Polyakova <m.polyakova@postgrespro.ru>
Discussion: https://www.postgresql.org/message-id/9ba4cd1ea6ed6b7b15c0ff15e6f540cd@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e59a67fb8fe1ac1408dc1858038f525a860d772b

Modified Files
--------------
src/backend/commands/dbcommands.c | 11 +++++++----
src/bin/scripts/t/020_createdb.pl |  4 ++++
2 files changed, 11 insertions(+), 4 deletions(-)