pgsql: Harmonize parameter names in storage and AM code.

Harmonize parameter names in storage and AM code.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in storage, catalog,
access method, executor, and logical replication code, as well as in
miscellaneous utility/library code.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.  Later commits will do the
same for other parts of the codebase.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bfcf1b34805f70df48eedeec237230d0cc1154a6

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c        |  3 +-
src/backend/access/common/reloptions.c             | 12 +++---
src/backend/access/gin/ginpostinglist.c            |  4 +-
src/backend/access/gist/gistbuild.c                |  5 ++-
src/backend/access/gist/gistbuildbuffers.c         |  4 +-
src/backend/access/gist/gistvacuum.c               |  2 +-
src/backend/access/transam/generic_xlog.c          |  2 +-
src/backend/access/transam/xact.c                  |  2 +-
src/backend/access/transam/xlog.c                  |  2 +-
src/backend/access/transam/xloginsert.c            | 18 ++++----
src/backend/access/transam/xlogreader.c            |  2 +-
src/backend/catalog/aclchk.c                       | 22 +++++-----
src/backend/catalog/namespace.c                    | 12 +++---
src/backend/commands/dbcommands.c                  |  8 ++--
src/backend/executor/execIndexing.c                |  2 +-
src/backend/executor/execParallel.c                |  4 +-
src/backend/executor/nodeAgg.c                     | 11 +++--
src/backend/executor/nodeHash.c                    |  6 +--
src/backend/executor/nodeHashjoin.c                |  6 +--
src/backend/executor/nodeMemoize.c                 |  4 +-
src/backend/lib/bloomfilter.c                      |  2 +-
src/backend/replication/logical/decode.c           |  4 +-
src/backend/replication/logical/worker.c           |  3 +-
src/backend/replication/pgoutput/pgoutput.c        |  4 +-
src/backend/replication/slot.c                     |  2 +-
src/backend/storage/buffer/bufmgr.c                |  4 +-
src/backend/storage/file/buffile.c                 |  2 +-
src/backend/storage/freespace/freespace.c          |  2 +-
src/backend/storage/ipc/dsm.c                      |  4 +-
src/backend/storage/ipc/procarray.c                |  2 +-
src/backend/storage/lmgr/lwlock.c                  | 12 +++---
src/backend/storage/lmgr/predicate.c               |  2 +-
src/backend/storage/smgr/md.c                      | 48 +++++++++++-----------
.../euc_jp_and_sjis/euc_jp_and_sjis.c              |  4 +-
.../euc_tw_and_big5/euc_tw_and_big5.c              |  2 +-
src/include/access/genam.h                         |  9 ++--
src/include/access/generic_xlog.h                  |  2 +-
src/include/access/gin_private.h                   | 12 +++---
src/include/access/gist_private.h                  | 18 ++++----
src/include/access/reloptions.h                    | 12 +++---
src/include/access/tupconvert.h                    |  2 +-
src/include/access/tupdesc.h                       |  2 +-
src/include/access/twophase.h                      |  2 +-
src/include/access/xact.h                          |  8 ++--
src/include/access/xlog.h                          |  8 ++--
src/include/access/xloginsert.h                    |  8 ++--
src/include/access/xlogreader.h                    |  2 +-
src/include/access/xlogrecovery.h                  |  4 +-
src/include/access/xlogutils.h                     |  4 +-
src/include/catalog/dependency.h                   |  6 +--
src/include/catalog/index.h                        |  4 +-
src/include/catalog/namespace.h                    |  2 +-
src/include/catalog/objectaccess.h                 | 12 +++---
src/include/catalog/objectaddress.h                |  4 +-
src/include/catalog/pg_conversion.h                |  2 +-
src/include/catalog/pg_inherits.h                  |  5 ++-
src/include/catalog/pg_publication.h               |  2 +-
src/include/commands/copy.h                        |  6 +--
src/include/commands/dbcommands_xlog.h             |  4 +-
src/include/executor/execParallel.h                |  4 +-
src/include/executor/executor.h                    |  6 +--
src/include/executor/nodeIncrementalSort.h         |  2 +-
src/include/executor/spi.h                         |  2 +-
src/include/mb/pg_wchar.h                          |  6 +--
src/include/miscadmin.h                            |  2 +-
src/include/replication/logical.h                  |  3 +-
src/include/replication/logicalproto.h             |  6 +--
src/include/replication/origin.h                   |  4 +-
src/include/replication/slot.h                     |  3 +-
src/include/replication/walsender.h                |  2 +-
src/include/storage/barrier.h                      |  2 +-
src/include/storage/bufpage.h                      |  4 +-
src/include/storage/dsm.h                          |  4 +-
src/include/storage/fd.h                           | 14 +++----
src/include/storage/fsm_internals.h                |  2 +-
src/include/storage/indexfsm.h                     |  4 +-
src/include/storage/lwlock.h                       |  2 +-
src/include/storage/predicate.h                    |  2 +-
src/include/storage/procarray.h                    |  2 +-
src/include/storage/standby.h                      |  2 +-
80 files changed, 228 insertions(+), 218 deletions(-)