pgsql: Ensure that CREATE TABLE LIKE copies any NO INHERIT constraint p

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Ensure that CREATE TABLE LIKE copies any NO INHERIT constraint p
Дата
Msg-id E1jBk11-0001DN-DG@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Ensure that CREATE TABLE LIKE copies any NO INHERIT constraint property.

Since the documentation about LIKE doesn't say that a copied constraint
has properties different from the original, it seems that ignoring
a NO INHERIT property doesn't meet the principle of least surprise.
So make it copy that.

(Note, however, that we still don't copy a NOT VALID property;
CREATE TABLE offers no way to do that, plus it seems pointless.)

Arguably this is a bug fix; but no back-patch, as it seems barely
possible somebody is depending on the current behavior.

Ildar Musin and Chris Travers; reviewed by Amit Langote and myself

Discussion: https://postgr.es/m/CAONYFtMC6C+3AWCVp7Yd8H87Zn0GxG1_iQG6_bQKbaqYZY0=-g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cacef172237fd3426b578f81b7414c0de56cbaaf

Modified Files
--------------
src/backend/parser/parse_utilcmd.c              | 11 +++++++----
src/test/regress/expected/create_table_like.out | 16 ++++++++++++++++
src/test/regress/sql/create_table_like.sql      | 11 +++++++++++
3 files changed, 34 insertions(+), 4 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Avoid portability problem introduced in 0a42a2e9c.
Следующее
От: Peter Geoghegan
Дата:
Сообщение: pgsql: nbtree: Demote minus infinity "can't happen" error.