Re: Defer selection of asynchronous subplans until the executor initialization stage

От

Zhihong Yu

Тема

Дата

10 апреля 2022 г. в 13:46:25

Msg-id

CALNJ-vRF1fw9dh-2sZW9bETqwcttOMw4ptLp6sOrzVUSw=Ycvw@mail.gmail.com

обсуждение

Ответ на

Re: Defer selection of asynchronous subplans until the executor initialization stage (Etsuro Fujita)

Список

pgsql-hackers

Дерево обсуждения

Re: Asynchronous Append on postgres_fdw nodes. "movead.li@highgo.ca" <movead.li@highgo.ca> 26 ноября 2020 г. в 01:28:06

Re: Asynchronous Append on postgres_fdw nodes. Craig Ringer <craig.ringer@enterprisedb.com> 30 ноября 2020 г. в 02:45:34

Re: Asynchronous Append on postgres_fdw nodes. Etsuro Fujita <etsuro.fujita@gmail.com> 20 декабря 2020 г. в 08:15:38

Re: Asynchronous Append on postgres_fdw nodes. Etsuro Fujita <etsuro.fujita@gmail.com> 2 января 2021 г. в 08:15:59

On Sun, Apr 10, 2022 at 3:42 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:

On Sat, Apr 9, 2022 at 1:58 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> On Fri, Apr 8, 2022 at 9:43 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > This patch seems to be causing the planner to crash.
> > Here's a query reduced from sqlsmith.
> >
> > | explain SELECT 1 FROM information_schema.constraint_column_usage WHERE 1 <= pg_trigger_depth();
> >
> > Program terminated with signal SIGSEGV, Segmentation fault.
>
> Reproduced. Will look into this.

I think the cause of this is that mark_async_capable_plan() failed to
take into account that when the given path is a SubqueryScanPath or
ForeignPath, the given corresponding plan might include a gating
Result node that evaluates pseudoconstant quals. My oversight. :-(
Attached is a patch for fixing that. I think v14 has the same issue,
so I think we need backpatching.

Best regards,
Etsuro Fujita