On Sat, Jan 27, 2018 at 4:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> No, that Assert is correct, because it's in SearchCatCacheList.
> It doesn't make any sense to use SearchCatCacheList for a lookup
> that specifies all of the key columns, because then you necessarily
> have at most one match; you might as well use regular SearchCatCache,
> which is significantly more efficient.
Ok the attached patch leaves that assert alone and uses
SearchSysCache4 for the Oid lookup. Everything still works.
If this looks generally alright-ish I'll start work on adding
float/double support as that's already been requested.