On Wed, Mar 14, 2018 at 10:11 PM, Stephen Frost <sfrost@snowman.net> wrote:
> Greetings Ashutosh,
>
> * Ashutosh Bapat (ashutosh.bapat@enterprisedb.com) wrote:
>> Here are two patches fixing comments.
>
> Thanks!
>
>> 0001
>> A comment in add_paths_to_append_rel() mentions the number of paths
>> instead of number of workers by mistake. Fixed it.
>
> This looks alright.
>
>> 0002
>> Commit b5635948ab165b6070e7d05d111f966e07570d81 added a single
>> grouping_sets_data argument instead of two lists related to grouping
>> sets to create_grouping_paths(), but forgot to update the prologue of
>> the function. Fixed it.
>
> This also looks good, but misses a similar mishap from that commit, in
> the function header of get_number_of_groups().
>
Thanks. The changes look good.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company