Re: [HACKERS] logical decoding of two-phase transactions

On Thu, Oct 15, 2020 at 2:16 PM Amit Kapila  wrote:
>
> On Wed, Oct 14, 2020 at 6:15 PM Ajin Cherian  wrote:
> >
>
> I think it will be easier to review this work if we can split the
> patches according to the changes made in different layers. The first
> patch could be changes made in output plugin and the corresponding
> changes in test_decoding, see the similar commit of in-progress
> transactions [1]. So you need to move corresponding changes from
> v8-0001-Support-decoding-of-two-phase-transactions and
> v8-0004-Support-two-phase-commits-in-streaming-mode-in-lo for this.
> The second patch could be changes made in ReorderBuffer to support
> this feature, see [2]. The third patch could be changes made to
> support pgoutput and subscriber-side stuff, see [3]. What do you
> think?

I agree. I have split the patches accordingly. Do have a look.
Pending work is:
1. Add pgoutput support for the new streaming two-phase commit APIs
2. Add test cases for two-phase commits with streaming for pub/sub and
test_decoding
3. Add CREATE SUBSCRIPTION command option to specify two-phase commits
rather than having it turned on by default.

regards,
Ajin Cherian
Fujitsu Australia