Re: duplicate function oid symbols

Поиск
Список
Период
Сортировка
Искать
От
John Naylor
Тема
Re: duplicate function oid symbols
Дата
Msg-id
CAFBsxsHjprmb9HCTwPGF9uf4OnDo1caA+q88E6MQdE5MG3o2Tg@mail.gmail.com
Ответ на
Список
Дерево обсуждения
duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>
Re: duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols Michael Paquier <michael@paquier.xyz>
Re: duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>
Re: duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols Andres Freund <andres@anarazel.de>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>
Re: duplicate function oid symbols Andres Freund <andres@anarazel.de>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>
Re: duplicate function oid symbols Andres Freund <andres@anarazel.de>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>
Re: duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols John Naylor <john.naylor@enterprisedb.com>
Re: duplicate function oid symbols Tom Lane <tgl@sss.pgh.pa.us>


On Tue, Oct 27, 2020 at 9:51 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
John Naylor <john.naylor@enterprisedb.com> writes:
> I noticed that the table AM abstraction introduced the symbol
> HEAP_TABLE_AM_HANDLER_OID, although we already have a convention for
> defining symbols automatically for builtin functions, which in this case is
> (currently unused) F_HEAP_TABLEAM_HANDLER.

Yeah, that seems wrong.  I'd just remove HEAP_TABLE_AM_HANDLER_OID.
As long as we're not back-patching the change, it seems like a very
minor thing to fix, if anyone outside core is referencing the old name.

Ok, here is a patch to fix that, and also throw an error if pg_proc.dat has an explicitly defined symbol.

--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company 
В списке pgsql-hackers по дате отправления
От: John Naylor
Дата:
От: Bruce Momjian
Дата:
FAQ