On Wed, 19 May 2021 at 12:07, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>
> Attached patch disactivates the test with comments to outline that there
> is an issue to fix… so it is *not* removed.
>
I opted to just remove the test rather than comment it out, since the
issue highlighted isn't specific to permute(). Also changing the PRNG
will completely change the results, so all the test values would
require rewriting, rather than it just being a case of uncommenting
the test and expecting it to work.
> I'm obviously okay with providing an alternate PRNG, let me know if this
> is the prefered option.
>
That's something for consideration in v15. If we do decide we want a
new PRNG, it should apply across the board to all pgbench random
functions.
Regards,
Dean