Re: Add some regression tests for SEQUENCE

Поиск
Список
Период
Сортировка
Искать
От
robins
Тема
Re: Add some regression tests for SEQUENCE
Дата
Msg-id
CAEP4nAyd78qR8Xjxjm_G4Ucm0arHn+OrKW9tvG_ABfMztf-2rA@mail.gmail.com
Ответ на
Re: Add some regression tests for SEQUENCE (robins)
Список
Дерево обсуждения
Add some regression tests for SEQUENCE robins <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Albe Laurenz <laurenz.albe@wien.gv.at>
Re: Add some regression tests for SEQUENCE robins <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE robins <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Robins Tharakan <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Josh Kupershmidt <schmiddy@gmail.com>
Re: Add some regression tests for SEQUENCE Robins Tharakan <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Robins Tharakan <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Fabien COELHO <coelho@cri.ensmp.fr>
Re: Add some regression tests for SEQUENCE Robert Haas <robertmhaas@gmail.com>
Re: Add some regression tests for SEQUENCE Robins Tharakan <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Fabien COELHO <coelho@cri.ensmp.fr>
Re: Add some regression tests for SEQUENCE Robins Tharakan <tharakan@gmail.com>
Re: Add some regression tests for SEQUENCE Fabien COELHO <coelho@cri.ensmp.fr>
Hi,

I've added some regression tests for SEQUENCE. A cumulative patch is attached.

Barring a (still to decipher) function seq_redo() and trying to learn how to actually test it, this takes care of most branches of (src/backend/commands/sequence.c) taking code-coverage (of 'make check') to ~95%. 

Any feedback is more than welcome.
--
Robins
Tharakan


On 13 March 2013 15:41, robins <tharakan@gmail.com> wrote:
Thanks Laurenz.

Would correct these (and readup) before submitting next patch.

--
Robins
Tharakan


On 13 March 2013 13:49, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:
robins wrote:
> Attached is a small patch to test corner cases related to Sequences (basically aimed at increasing
> code-coverage of sequence.sql in regression tests).
>
> Look forward to any and all feedback.

Looks ok except that the patch is backwards
(all added lines start with "-").  I found a typo:
"exit" instead of "exist".

You should add the patch to the next commitfest
(http://wiki.postgresql.org/wiki/Submitting_a_Patch).

Yours,
Laurenz Albe


В списке pgsql-hackers по дате отправления
Предыдущее
От: Kevin Grittner
Дата:
Следующее
От: Alvaro Herrera
Дата:
FAQ