Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
От
Максим Орлов
Тема
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Дата
Msg-id
CACG=ezZYRH6u5a642_TC+LidT8UKACN+UU48B07ioJFnZ5aOtA@mail.gmail.com
Ответ на
Список
Дерево обсуждения
[PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Mark Dilger <mark.dilger@enterprisedb.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Zhihong Yu <zyu@yugabyte.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
The pstrdup is unnecessary but harmless.
> - use the existing table for uniqueness check in 005_opclass_damage.pl
It appears you still create a new table, bttest_unique, rather than using the existing table int4tbl. That's fine.
> - added tests into 003_check.pl . It is only smoke test that just verifies new functions.
You have borrowed the existing tests but forgot to change their names. (The last line of each check is the test name, such as 'pg_amcheck smoke test --parent-check'.) Please make each test name unique.
Thanks for your review! Fixed all these remaining things from patch v6.
PFA v7 patch.
---
Best regards,
Maxim Orlov.
В списке pgsql-hackers по дате отправления
