Re: Teach pg_receivewal to use lz4 compression
От
Magnus Hagander
Тема
Re: Teach pg_receivewal to use lz4 compression
Дата
Msg-id
CABUevEyWmN-1ksHT6gnsC_e7x4AJSUr+xz=NeOo60ESKNeTntw@mail.gmail.com
Ответ на
Re: Teach pg_receivewal to use lz4 compression (Michael Paquier)
Список
Дерево обсуждения
Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Dilip Kumar <dilipbalaut@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Magnus Hagander <magnus@hagander.net>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Magnus Hagander <magnus@hagander.net>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Dilip Kumar <dilipbalaut@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Magnus Hagander <magnus@hagander.net>
Re: Teach pg_receivewal to use lz4 compression Dilip Kumar <dilipbalaut@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Jian Guo <gjian@vmware.com>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Magnus Hagander <magnus@hagander.net>
Re: Teach pg_receivewal to use lz4 compression Robert Haas <robertmhaas@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Robert Haas <robertmhaas@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Justin Pryzby <pryzby@telsasoft.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Robert Haas <robertmhaas@gmail.com>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Re: Teach pg_receivewal to use lz4 compression Robert Haas <robertmhaas@gmail.com>
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
Re: Teach pg_receivewal to use lz4 compression Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Re: Teach pg_receivewal to use lz4 compression gkokolatos@pm.me
Re: Teach pg_receivewal to use lz4 compression Michael Paquier <michael@paquier.xyz>
On Tue, Nov 2, 2021 at 9:51 AM Michael Paquier <michael@paquier.xyz> wrote:
On Tue, Nov 02, 2021 at 07:27:50AM +0900, Michael Paquier wrote:
> On Mon, Nov 01, 2021 at 08:39:59AM +0000, gkokolatos@pm.me wrote:
> > Agreed.
> >
> > I have already started on v8 of the patch with that technique. I should
> > be able to update the thread soon.
>
> Nice, thanks!
By the way, I was reading the last version of the patch today, and
it seems to me that we could make the commit history if we split the
patch into two parts:
- One that introduces the new option --compression-method and
is_xlogfilename(), while reworking --compress (including documentation
changes).
- One to have LZ4 support.
v7 has been using "gzip" for the option name, but I think that it
would be more consistent to use "zlib" instead.
Um, why?
That we are using zlib to provide the compression is an implementation detail. Whereas AFAIK "gzip" refers to both the program and the format. And we specifically use the gzxxx() functions in zlib, in order to produce gzip format.
I think for the end user, it is strictly better to name it "gzip", and given that the target of this option is the end user we should do so. (It'd be different it we were talking about a build-time parameter to configure).
В списке pgsql-hackers по дате отправления
От: osumi.takamichi@fujitsu.com
Дата:
