Re: Small patch to fix build on Windows
От
Dmitry Igrishin
Тема
Re: Small patch to fix build on Windows
Дата
Msg-id
CAAfz9KMKPqFEcxb3wdFJpEmEdcfr-OYZWuj6xm8udSw=Oy0B5A@mail.gmail.com
Ответ на
Re: Small patch to fix build on Windows (Alvaro Herrera)
Список
Дерево обсуждения
Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Small patch to fix build on Windows Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Michael Paquier <michael@paquier.xyz>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Michael Paquier <michael@paquier.xyz>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
Re: Small patch to fix build on Windows Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: Small patch to fix build on Windows Dmitry Igrishin <dmitigr@gmail.com>
чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera :
>
> On 2019-Aug-08, Dmitry Igrishin wrote:
>
> > my $prefixcmd =
> > - $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
> > + "\"$solution->{options}->{python}\\python\" -c \"$pythonprog\"";
>
> I think you can make this prettier like this:
>
> my $prefixcmd = qq{"$solution->{options}->{python}\\python" -c "$pythonprog"};
This looks nice for a Perl hacker :-). As for me, it looks unusual and
a bit confusing. I never
programmed in Perl, but I was able to quickly understand where the
problem lies due to the
style adopted in other languages, when the contents are enclosed in
quotation marks, and
the quotation marks are escaped if they are part of the contents.
So, should I fix it? Any thoughts?
В списке pgsql-hackers по дате отправления
От: Stephen Frost
Дата: