Re: extensible external toast tuple support

On Thu, Jun 27, 2013 at 12:56 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> Please find attached the next version of the extensible toast
> support. There basically are two changes:
>
> * handle indirect toast tuples properly in heap_tuple_fetch_attr
>   and related places
> * minor comment adjustments

It looks to me like you need to pass true, rather than false, as the
first argument to TrapMacro:

+#define VARTAG_SIZE(tag) \
+       ((tag) == VARTAG_INDIRECT ? sizeof(varatt_indirect) :           \
+        (tag) == VARTAG_ONDISK ? sizeof(varatt_external) : \
+        TrapMacro(false, "unknown vartag"))

Still looking at the rest of this.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company