Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?'property throws error for Materialized View."

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?'property throws error for Materialized View."
Дата
Msg-id CA+OCxox8ZfZ5ktapzMsMSFcXHmYtT6ZCeJC7y0+epB6V-u0D-A@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' propertythrows error for Materialized View."  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?'property throws error for Materialized View."  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi

On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

I have started working on RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View." and while working I have figured out following issues:
  • Reset some/all the parameter for table and toast table is not implemented. 
  • Value of "Custom auto-vacuum?" is not retrieved and set properly.
  • When user set the "Custom auto-vacuum?" to "Yes" and none of the parameter is set previously then set the value of "Enabled?" control to "Yes".
  • Alignment of Table and remove extra margin from "Parameters" tab. 
Attached is the patch to fix all the above issues. Added API test cases.
Please review it.

I set the autovacuum_enabled=true and autovacuum_analyze_scale_factor=1 on the test mview, but only the enabled setting is reflected when I re-open the properties dialogue. Other settings seems to be fine - it's just autovacuum_analyze_scale_factor that's broken.

It's also not shown in the reverse-engineered SQL - neither is  autovacuum_enabled.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Usman Muzaffar
Дата:
Сообщение: Feature Tests query tool: unnecessary print statement removal
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?'property throws error for Materialized View."