Re: Covering GiST indexes

Thanks! Here's new version 8

> 29 янв. 2019 г., в 22:00, Andreas Karlsson <andreas@proxel.se> написал(а):
>
> * I think it is worth writing a short comment when you create truncTupdesc about why this is done.
It resulted in not so short comment, but I think it is OK.
>
> * Very minor thing: the diff below is pointless churn on a line not touched by the patch.
>
> -                        values, isnull, true /* size is currently bogus */ );
> +                        values, isnull, true /* size is currently bogus */);
Fixed.
>
> * Another very minor thing: The diff below from gistFormTuple() should probably be consistent about brackets.
>
> +           if (isnull[i])
> +               compatt[i] = (Datum) 0;
> +           else
> +           {
> +               compatt[i] = attdata[i];
> +           }
Fixed.


Also, I've unified gist and r-tree syntax tests for INCLUDE.

Best regards, Andrey Borodin.