Re: [HACKERS] Fix a typo in execReplication.c

On 12/10/17 00:52, Masahiko Sawada wrote:
> On Thu, Oct 12, 2017 at 5:02 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Mon, Oct 9, 2017 at 10:59 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>> Attached a patch for $subject. ISTM these are mistakes of copy-and-paste.
>>
>> Committed, but isn't the code itself wrong as well in the DELETE case?
>>
>>     /* BEFORE ROW DELETE Triggers */
>>     if (resultRelInfo->ri_TrigDesc &&
>>         resultRelInfo->ri_TrigDesc->trig_update_before_row)
>>     {
>>         skip_tuple = !ExecBRDeleteTriggers(estate, epqstate, resultRelInfo,
>>                                            &searchslot->tts_tuple->t_self,
>>                                            NULL);
>>     }
>>
>> Why not trig_delete_before_row?
>>

Indeed, that's another copy-pasto.

> 
> Thank you!
> I think you're right. It should be trig_delete_before_row and be
> back-patched to 10. Attached patch fixes it.
> 

Thanks for the patch, looks correct to me.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers