Re: Partial aggregates pushdown

Alexander Pyhalov писал 2022-01-17 15:26:
> Zhihong Yu писал 2022-01-17 11:43:
>> Hi,
>> +   FdwScanPrivateConvertors
>> 
>> + * Generate attinmeta if there are some converters:
>> 
>> I think it would be better if converter is spelled the same way across
>> the patch.
>> 
>> For build_conv_list():
>> 
>> +   if (IS_UPPER_REL(foreignrel))
>> 
>> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
>> indentation for the body of the func.
> 
> Hi.
> Updated patch.

Sorry, missed attachment.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional