Re: ISM shared memory on solaris

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: ISM shared memory on solaris
Дата
Msg-id
853.1067278484@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
ISM shared memory on solaris Josh Wilmes <jwilmes@cisco.com>
Re: ISM shared memory on solaris Bruce Momjian <pgman@candle.pha.pa.us>
Re: ISM shared memory on solaris Josh Wilmes <jwilmes@cisco.com>
Re: ISM shared memory on solaris Bruce Momjian <pgman@candle.pha.pa.us>
Re: ISM shared memory on solaris Josh Wilmes <jwilmes@cisco.com>
Re: ISM shared memory on solaris Bruce Momjian <pgman@candle.pha.pa.us>
Re: ISM shared memory on solaris Tom Lane <tgl@sss.pgh.pa.us>
Re: ISM shared memory on solaris Bruce Momjian <pgman@candle.pha.pa.us>
Re: ISM shared memory on solaris Josh Wilmes <jwilmes@cisco.com>
Re: ISM shared memory on solaris Bruce Momjian <pgman@candle.pha.pa.us>
Bruce Momjian  writes:

> ! #if defined(sun) && defined(__sparc__)
>   	/* use intimate shared memory on SPARC Solaris */
>   	memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
>   #else

I think this is going in the wrong direction.  Why isn't the code just

#if defined(SHM_SHARE_MMU)
	/* use intimate shared memory on Solaris */
	memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
#else

If the symbol is available I think we probably want to use it.  It is an
O/S issue, not a hardware issue, and so the test on __sparc__ seems
quite wrongheaded ...

			regards, tom lane
В списке pgsql-bugs по дате отправления
От: Tom Lane
Дата:
От: Bruce Momjian
Дата:
FAQ