Re: pgsql: Add all structured objects passed to pushJsonbValue piecewise.

On 5/26/15 11:24 AM, Andrew Dunstan wrote:
> Add all structured objects passed to pushJsonbValue piecewise.
>
> Commit 9b74f32cdbff8b9be47fc69164eae552050509ff did this for objects of
> type jbvBinary, but in trying further to simplify some of the new jsonb
> code I discovered that objects of type jbvObject or jbvArray passed as
> WJB_ELEM or WJB_VALUE also caused problems. These too are now added
> component by component.
>
> Backpatch to 9.4.

This causes a compiler warning:

jsonb_util.c: In function 'pushJsonbValue':
jsonb_util.c:535:3: error: passing argument 1 of 'JsonbIteratorInit'
from incompatible pointer type [-Werror]
   it = JsonbIteratorInit(jbval);
   ^
In file included from jsonb_util.c:20:0:
../../../../src/include/utils/jsonb.h:422:23: note: expected 'struct
JsonbContainer *' but argument is of type 'struct JsonbValue *'
 extern JsonbIterator *JsonbIteratorInit(JsonbContainer *container);
                       ^