On 6/13/13 5:35 AM, Dean Rasheed wrote:
> Attached is a patch implementing a new aggregate function md5_agg() to
> compute the aggregate MD5 sum across a number of rows.
That seems somewhat useful.
> In passing, I've tidied up and optimised the code in md5.c a bit ---
> specifically I've removed the malloc()/memcpy()/free() code that was
> unnecessarily making a copy of the entire input data just to pad it
> and append the bit count. This reduces the memory consumption of the
> existing md5() functions for large inputs, and gives a modest
> performance boost. As a result, the md5() function can no longer throw
> an out-of-memory error.
I think it would be better if you split this into two separate patches.