Re: Proposed patch - psql wraps at window width

Поиск
Список
Период
Сортировка
Искать
От
Bryce Nesbitt
Тема
Re: Proposed patch - psql wraps at window width
Дата
Msg-id
4808415E.5080905@obviously.com
Ответ на
Список
Дерево обсуждения
Re: Coding standards Chris Browne <cbbrowne@acm.org>


Alvaro Herrera wrote:
> * Don't lose warning comments like this one (unless you've removed the
> assumption of course)
>
> /*
>  * Assumption: This code used only on strings
>  * without multibyte characters, otherwise
>  * this_line->width < strlen(this_ptr) and we get
>  * an overflow
>  */
In fact, that particular assumption was causing a problem, causing a 
segfault.  I can't be certain, because the multibyte stuff is pretty 
intense, but I think I nailed it.  Thanks for all your comments!

В списке pgsql-patches по дате отправления
От: Tom Lane
Дата:
От: Bryce Nesbitt
Дата:
Сообщение: Coding standards
FAQ