Re: [PATCH] Phrase search ported to 9.6

Поиск
Список
Период
Сортировка
Искать
От
Dmitry Ivanov
Тема
Re: [PATCH] Phrase search ported to 9.6
Дата
Msg-id
3434940.RE8VbBU72A@abook
Ответ на
Список
Дерево обсуждения
[PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Artur Zakirov <a.zakirov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Artur Zakirov <a.zakirov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 David Steele <david@pgmasters.net>
Re: [PATCH] Phrase search ported to 9.6 Artur Zakirov <a.zakirov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 David Steele <david@pgmasters.net>
Re: [PATCH] Phrase search ported to 9.6 Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Teodor Sigaev <teodor@sigaev.ru>
Re: [PATCH] Phrase search ported to 9.6 Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PATCH] Phrase search ported to 9.6 Oleg Bartunov <obartunov@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PATCH] Phrase search ported to 9.6 Teodor Sigaev <teodor@sigaev.ru>
Re: [PATCH] Phrase search ported to 9.6 Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PATCH] Phrase search ported to 9.6 Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH] Phrase search ported to 9.6 Oleg Bartunov <obartunov@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Teodor Sigaev <teodor@sigaev.ru>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Teodor Sigaev <teodor@sigaev.ru>
Re: [PATCH] Phrase search ported to 9.6 Andreas Joseph Krogh <andreas@visena.com>
Re: [PATCH] Phrase search ported to 9.6 Dmitry Ivanov <d.ivanov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 David Steele <david@pgmasters.net>
Re: [PATCH] Phrase search ported to 9.6 Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Phrase search ported to 9.6 David Steele <david@pgmasters.net>
Re: [PATCH] Phrase search ported to 9.6 Michael Paquier <michael.paquier@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Andreas Joseph Krogh <andreas@visena.com>
Re: [PATCH] Phrase search ported to 9.6 Oleg Bartunov <obartunov@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Andreas Joseph Krogh <andreas@visena.com>
Re: [PATCH] Phrase search ported to 9.6 Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PATCH] Phrase search ported to 9.6 Robert Haas <robertmhaas@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Oleg Bartunov <obartunov@gmail.com>
Re: [PATCH] Phrase search ported to 9.6 Andreas Joseph Krogh <andreas@visena.com>
Hi, Artur

I've made an attempt to fix some of the issues you've listed, although there's 
still much work to be done. I'll add some comments later.

> This function has the duplicated piece from the tsvector_setweight()
> from tsvector_op.c. You can define new function for it.

I'm not sure it's worth the trouble. IMO these functions are relatively small 
and we won't benefit from extracting the duplicate code.

> These functions was removed in 9acb9007de30b3daaa9efc16763c3bc6e3e0a92d.
> It seems that tsvector_op.c was not synchronized with the master.

Got it, thanks!

-- 
Dmitry Ivanov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
В списке pgsql-hackers по дате отправления
От: Tom Lane
Дата:
От: Pavel Stehule
Дата:
FAQ