On Wed, Apr 03, 2024 at 06:11:47PM -0700, David G. Johnston wrote:
> On Sat, Mar 30, 2024 at 11:16 PM Noah Misch <noah@leadboat.com> wrote:
> > On Tue, Jan 30, 2024 at 01:49:42PM -0700, David G. Johnston wrote:
> > > + The membership grants created by the
> > > + <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
> > <literal>ADMIN</literal>
> > > + clauses have the role executing this command as the grantee.
> >
> > This should be s/grantee/grantor/, right?
>
> Correct.
>
> > > + If unspecified when create a new role membership this defaults to
> > > + the inheritance attribute of the role being added.
> >
> > Need s/create/creating/. Missing comma. While phrase "role being added"
> > isn't wrong, the rest of the paragraph uses "member" and uses "granted
> > role"
> > to refer to the member-of role. Putting those together:
> >
> > If unspecified when creating a new role membership, this defaults to the
> > inheritance attribute of the new member.
>
> I like that better.
Pushed as 68ba46d. Thanks for reviewing.