Re: Portal->commandTag as an enum

On 2020-Feb-28, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > I just realized that we could rename command_tag_display_last_oid() to
> > something like command_tag_print_a_useless_zero_for_historical_reasons() 
> > and nothing would be lost.
> 
> Is there a way to drop that logic altogether by making the tagname string
> be "INSERT 0" for the INSERT case?  Or would the zero bleed into other
> places where we don't want it?

Hmm, interesting thought. But yeah, it would show up in ps display:

        commandTag = CreateCommandTag(parsetree->stmt);

        set_ps_display(GetCommandTagName(commandTag), false);

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services