Re: Patch for SortSupport implementation on inet/cdir

Поиск
Список
Период
Сортировка
Искать
От
Andres Freund
Тема
Re: Patch for SortSupport implementation on inet/cdir
Дата
Msg-id
20190216021309.zj6yopjqkqo4hw7j@alap3.anarazel.de
Ответ на
Список
Дерево обсуждения
Patch for SortSupport implementation on inet/cdir Brandur Leach <brandur@mutelight.org>
Re: Patch for SortSupport implementation on inet/cdir Brandur Leach <brandur@mutelight.org>
Re: Patch for SortSupport implementation on inet/cdir Peter Geoghegan <pg@bowt.ie>
Re: Patch for SortSupport implementation on inet/cdir Peter Geoghegan <pg@bowt.ie>
Re: Patch for SortSupport implementation on inet/cdir Brandur Leach <brandur@mutelight.org>
Re: Patch for SortSupport implementation on inet/cdir Brandur Leach <brandur@mutelight.org>
Re: Patch for SortSupport implementation on inet/cdir Peter Geoghegan <pg@bowt.ie>
Re: Patch for SortSupport implementation on inet/cdir Brandur Leach <brandur@mutelight.org>
Re: Patch for SortSupport implementation on inet/cdir Peter Geoghegan <pg@bowt.ie>
Re: Patch for SortSupport implementation on inet/cdir Edmund Horner <ejrh00@gmail.com>
Re: Patch for SortSupport implementation on inet/cdir Andres Freund <andres@anarazel.de>
Re: Re: Patch for SortSupport implementation on inet/cdir David Steele <david@pgmasters.net>
Re: Patch for SortSupport implementation on inet/cdir Peter Geoghegan <pg@bowt.ie>
Hi Brandur,


On 2019-02-09 20:12:53 +1300, Edmund Horner wrote:
> I had a look at this.  Your V2 patch applies cleanly, and the code was
> straightforward and well commented.  I appreciate the big comment at the
> top of network_abbrev_convert explaining how you encode the data.

I've marked the CF entry as waiting-on-author, due to this review.

Brandur, unfortunately this patch has only been submitted to the last
commitfest for v12. Our policy is that all nontrivial patches should be
submitted to at least one earlier commitfest. Therefore I unfortunately
think that v12 is not a realistic target, sorry :(

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления
От: Benjamin Manes
Дата:
От: Andres Freund
Дата:
FAQ