Re: Optimize Arm64 crc32c implementation in Postgresql

On 2018-03-02 11:37:52 +1300, Thomas Munro wrote:
> So... that stuff probably needs either a configure check for the
> getauxval function and/or those headers, or an OS check?

It'd probably be better to not rely on os specific headers, and instead
directly access the capabilities.


> While I'm looking at this:
> 
> -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62))
> +#define LARGE_OFF_T ((((off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) << 31))
> 
> Why?  Doesn't something << 62 have the same value and type as
> (something << 31) << 31?

> +  --runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]
> 
> What is this for?

Those probably are damage from using a distribution autoconf rather than
stock autoconf.

Greetings,

Andres Freund