Re: Tsvector editing functions
От
Alvaro Herrera
Тема
Re: Tsvector editing functions
Дата
Msg-id
20160118212103.GA132670@alvherre.pgsql
Ответ на
Re: Tsvector editing functions (Stas Kelvich)
Список
Дерево обсуждения
Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Tsvector editing functions Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Stas Kelvich <s.kelvich@postgrespro.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Michael Paquier <michael.paquier@gmail.com>
Re: Tsvector editing functions Robert Haas <robertmhaas@gmail.com>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
Re: Tsvector editing functions Teodor Sigaev <teodor@sigaev.ru>
So, Tomas, Teodor, did you like this new version of the patch? Stas Kelvich wrote: > > 7) Some of the functions use intexterm that does not match the function > > name. I see two such cases - to_tsvector and setweight. Is there a > > reason for that? > > Because sgml compiler wants unique indexterm. Both functions that you > mentioned use overloading of arguments and have non-unique name. This sounds wrong. I think what you should really do is use foo bar to distinguish the two entries. It's a bit funny that you reintroduce the "unrecognized weight: %d" (instead of %c) in tsvector_setweight_by_filter. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления
От: Robert Haas
Дата: