Re: A minor correction in comment in heaptuple.c

On 2013-06-18 13:14:30 -0400, D'Arcy J.M. Cain wrote:
> On Tue, 18 Jun 2013 11:38:45 +0200
> Andres Freund  wrote:
> > > How about "check if attnum is out of range according to the tupdesc"
> > > instead?
> > 
> > I can't follow. Minus the word 'NULL' - which carries meaning - your
> > suggested comment pretty much is the same as the existing comment
> > except that you use 'check' instead of 'return'.
> 
> The difference is that I say what the purpose of the function is but
> don't say what it actually returns.  The code itself does that.
>
> > Original:
> > 	/*
> > 	 * return NULL if attnum is out of range according to the
> > tupdesc */
> 
> Obviously wrong so it should be changed.

The NULL refers to the *meaning* of the function (remember, it's called
slot_attisnull) . Which is to test whether an attribute is null. Not to
a C NULL.

Greetings,

Andres Freund

-- Andres Freund	                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services