Re: Inaccurate error message when set fdw batch_size to 0

Поиск
Список
Период
Сортировка
Искать
От
Fujii Masao
Тема
Re: Inaccurate error message when set fdw batch_size to 0
Дата
в 06:17:28
Msg-id
1d27d8f1-123a-3d3e-cd71-e253b80efdb9@oss.nttdata.com
Ответ на
Список
Дерево обсуждения
Inaccurate error message when set fdw batch_size to 0 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Re: Inaccurate error message when set fdw batch_size to 0 Dilip Kumar <dilipbalaut@gmail.com>
RE: Inaccurate error message when set fdw batch_size to 0 "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Tom Lane <tgl@sss.pgh.pa.us>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Tom Lane <tgl@sss.pgh.pa.us>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Amit Kapila <amit.kapila16@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Inaccurate error message when set fdw batch_size to 0 Fujii Masao <masao.fujii@oss.nttdata.com>
Re: Inaccurate error message when set fdw batch_size to 0 Michael Paquier <michael@paquier.xyz>


On 2021/05/10 10:26, tsunakawa.takay@fujitsu.com wrote:
> From: houzj.fnst@fujitsu.com 
>> So, is it better to change the error message to “fetch_size requires a positive integer value” ?
>> I also found fetch_size has the similar issue, attaching a patch to fix this.
> 
> I have a faint memory that I fixed them after receiving the same feedback from someone else, strange...  Anyway, thanks.

+1 for the change of the error messages.

One question is; should we back-patch the change of the error message about
fetch_size to back branches? Since this is minor thing, is it enough to apply
the change only to the master? Even if we should do the back-patch,
we would need to wait until upcoming minor release is done before doing that.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION


В списке pgsql-hackers по дате отправления
От: Laurenz Albe
Дата:
От: Michael Paquier
Дата:
FAQ