Re: Bogus sizing parameters in some AllocSetContextCreate calls
| От | Tom Lane |
|---|---|
| Тема | Re: Bogus sizing parameters in some AllocSetContextCreate calls |
| Дата | |
| Msg-id | 14922.1472395319@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: Bogus sizing parameters in some AllocSetContextCreate calls (Robert Haas <robertmhaas@gmail.com>) |
| Ответы |
Re: Bogus sizing parameters in some AllocSetContextCreate
calls
Re: Bogus sizing parameters in some AllocSetContextCreate calls |
| Список | pgsql-hackers |
Robert Haas <robertmhaas@gmail.com> writes:
> Also, I think we ought to replace this code in aset.c:
> initBlockSize = MAXALIGN(initBlockSize);
> if (initBlockSize < 1024)
> initBlockSize = 1024;
> maxBlockSize = MAXALIGN(maxBlockSize);
> With this:
> Assert(initBlockSize >= 1024 && initBlockSize == MAXALIGN(initBlockSize));
> Assert(maxBlockSize == MAXALIGN(maxBlockSize));
Good idea --- if we'd had it that way, these errors would never have
gotten committed in the first place. I'm for doing that only in HEAD
though.
regards, tom lane
В списке pgsql-hackers по дате отправления: