Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much
Дата
Msg-id 13328.1508706669@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Ответы Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-bugs
Дерево обсуждения 
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> Sorry. Here it is.

This comment is neither correct nor intelligible:
/* important for value, key cannot being NULL */

I'd say just drop it.

The checks for "could not determine data type" errors seem
rather duplicative, too.

<compulsive-neatnik-ism>
The extern declaration seems to have been dropped in a rather
random place in the .h file.
</compulsive-neatnik-ism>

Looks good otherwise.
        regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC callsvery much