Re: [HACKERS] Minor changes to Recovery related code

On Thu, 2008-03-27 at 17:34 +0000, Simon Riggs wrote:
> Follow-up during March 2008 CommitFest
> 
> On Thu, 2007-06-07 at 21:53 +0100, Simon Riggs wrote:
> > On Sat, 2007-03-31 at 00:51 +0200, Florian G. Pflug wrote:

> > - pg_stop_backup() will wait until the WAL file that ends the backup is
> > safely archived, even if a failure to archive occurs. This is a change
> > to current behaviour, but since it implements the originally *expected*
> > behaviour IMHO it should be the default.
> 
> The most straightforward thing is to make pg_stop_backup() wait as
> described above.
> 
> If people want it to timeout, they can use a statement_timeout as
> suggested by Florian.
> 
> This can be implemented by having the function poll in an infinite loop
> for archive_status/LOG.done. Also, as Florian suggests, we should have
> it output a WARNING message every 60 seconds.
> 
> I'll write a patch now.

Patch to implement waiting pg_stop_backup(). 

Tested and ready to apply, includes docs.

-- 
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com 

  PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk