Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE

Поиск
Список
Период
Сортировка
Искать
От
Heikki Linnakangas
Тема
Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE
Дата
Msg-id
07b33e2c-46a6-86a1-5f9e-a7da73fddb95@iki.fi
Список
Дерево обсуждения
Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE Heikki Linnakangas <hlinnaka@iki.fi>
Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE Amit Kapila <amit.kapila16@gmail.com>
Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE Michael Paquier <michael@paquier.xyz>
Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE Heikki Linnakangas <hlinnaka@iki.fi>
While hacking on pg_rewind, I noticed that commit and abort WAL records 
are never marked with the XLR_SPECIAL_REL_UPDATE flag. But if the record 
contains "dropped relfilenodes", surely it should be?

It's harmless as far as the backend and all the programs in PostgreSQL 
repository are concerned, but the point of XLR_SPECIAL_REL_UPDATE is to 
aid external tools that try to track which files are modified. Attached 
is a patch to fix it.

It's always been like that, but I am not going backport, for fear of 
breaking existing applications. If a program reads the WAL, and would 
actually need to do something with commit records dropping relations, 
that seems like such a common scenario that the author should've thought 
about it and handled it even without the flag reminding about it. Fixing 
it in master ought to be enough.

Thoughts?

- Heikki
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Julien Rouhaud
Дата:
Сообщение: Re: Collation versioning
FAQ